Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashes are not allowed in did domain names #816

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Dashes are not allowed in did domain names #816

merged 1 commit into from
Aug 27, 2024

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@tnotheis tnotheis added the bug Something isn't working label Aug 27, 2024
@tnotheis tnotheis requested a review from jkoenig134 August 27, 2024 09:13
@tnotheis tnotheis enabled auto-merge (squash) August 27, 2024 09:13
@tnotheis tnotheis disabled auto-merge August 27, 2024 09:19
@tnotheis tnotheis merged commit 6f1ee18 into main Aug 27, 2024
25 checks passed
@tnotheis tnotheis deleted the did-domain-names-are-not-allowed-to-contain-dashes branch August 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnotheis @jkoenig134